x86_emulate: fix unintended writeback on cmp/test instructions
authorKeir Fraser <keir.fraser@citrix.com>
Fri, 25 Jul 2008 13:00:27 +0000 (14:00 +0100)
committerKeir Fraser <keir.fraser@citrix.com>
Fri, 25 Jul 2008 13:00:27 +0000 (14:00 +0100)
commit26c26ff17aabf675863b9882eee186fafbb5ff4e
treec6cd384fd97ddf43a0dbe06e30ff901dddc5a1a8
parentf6e4baff8280c1960636aa48787d7956fb7dcce8
x86_emulate: fix unintended writeback on cmp/test instructions

This patch fixes an issue when x86_emulate is called with
force_writeback=1 set. It resulted in cmp and test instructions with
memory operands to have the mem value written back after instruction
emulation finished. This caused false alarms on writes to RO mem, and
might have caused other issues if unintended writes occured to device
registers in mmio space.

Signed-off-by: Trolle Selander <trolle.selander@eu.citrix.com>
xen/arch/x86/x86_emulate/x86_emulate.c